owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.35k stars 172 forks source link

Environment variable consolidation #8259

Open dragonchaser opened 7 months ago

dragonchaser commented 7 months ago

At the moment we have tons of redundant environment variables that do not make sense IMHO. For example we configure OCIS_LOG_LEVEL, OCIS_LOG_PRETTY, OCIS_LOG_COLOR, OCIS_LOG_FILE for every service. It would be sufficient to define three of them (OCIS_LOG_PRETTY, OCIS_LOG_COLOR and OCIS_LOG_FILE) globally and just define a log level per service. This also applies to other variables and variable groups (e.g. Debug, RevaGateway etc.).

dragonchaser commented 7 months ago

/cc @micbar && @mmattel

butonic commented 6 months ago

The reason for different prefixes is to allow changing the configuration of individual services when running in a single process.

We shoud phase out as many service specific variables as soon as possible. But they will need to stay in for backwards compatability.

I'm looking at the ServiceAccountsID env var which is another special case as every service should use a dedicated service account id. but then the settings service needs to know all accounts...

dragonchaser commented 6 months ago

The reason for different prefixes is to allow changing the configuration of individual services when running in a single process.

We shoud phase out as many service specific variables as soon as possible. But they will need to stay in for backwards compatability.

Already possible, using our deprecation system, it would be awesome if we could get rid of that with 6.0. It would be desirable to have only one variable per annotation and move global vars to ocis-pkg

I'm looking at the ServiceAccountsID env var which is another special case as every service should use a dedicated service account id. but then the settings service needs to know all accounts...

:+1:

butonic commented 6 months ago

And we need to clarify how config parsing works in the docs https://owncloud.dev/ocis/config/

fschade commented 1 month ago

UP