[contract testing] [share ng] Extend propfind contract testing

amrita-shrestha commented 6 months ago

While adding tests related to share-ng, found that ocis-tests miss some contract testing as mentioned below. Scenario: remove share link and propfind resource to see if the response contain or not

<oc:share-types>
<oc:share-type>3</oc:share-type>
</oc:share-types>
<oc:privatelink>
https://localhost:9200/f/a3be74ba-6183-4942-9458-440b92c5895b$68962830-8cbb-4226-b3b4-458c50793487%210e590fe7-8816-4d75-bd42-5ffa2fa81410
</oc:privatelink>

Scenario: user Alice shared resource with user Brian, Brian is deleted , user Alice propfind the shared resource to check if the response contains shares details or not after share deleted

Question

Should we add such scenario to apiContract->propfind.feature ❓

cc @ScharfViktor @saw-jan @phil-davis

S-Panta commented 4 months ago

The bug is reported here . https://github.com/owncloud/ocis/issues/9463

SagarGi commented 4 months ago

For the above issue first lets find out if we have covered propfind test when sharee is not deleted. If it is not covered then we can add one when sharee is not deleted. And then we can check the propfind when sharee gets deleted.

In summary:

[x] Check for propfind test when sharer do a propfind for shared resources (sharee is not deleted). if there not then add one https://github.com/owncloud/ocis/pull/9563
[ ] Check for propfind test when sharer do a propfind for shared resources (sharee is deleted). https://github.com/owncloud/ocis/issues/9463

Also consider this bug regarding it. https://github.com/owncloud/ocis/issues/9463

PrajwolAmatya commented 4 months ago

Moving this issue to blocked since there's an issue regarding PROPFIND request to shared resource when the user is deleted. Reported here: https://github.com/owncloud/ocis/issues/9463

owncloud / ocis

[contract testing] [share ng] Extend propfind contract testing #9119

Question