owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.25k stars 169 forks source link

[QA] API test WebDav downloadedContentWhenDownloadingWithRangeShouldBe #9345

Open phil-davis opened 3 weeks ago

phil-davis commented 3 weeks ago

Describe the bug

    /**
     * @Then /^the downloaded content when downloading file "([^"]*)" with range "([^"]*)" should be "([^"]*)"$/
     *
     * @param string $fileSource
     * @param string $range
     * @param string $content
     *
     * @return void
     */
    public function downloadedContentWhenDownloadingWithRangeShouldBe(
        string $fileSource,
        string $range,
        string $content
    ):void {
        $this->checkDownloadedContentMatches($content);
    }

$fileSource and $range are not used. That looks strange.

Investigate what the step is doing, and where it is used in scenarios. Fixup the step code, or delete it if it is unused.

Setup

CI

prashant-gurung899 commented 2 days ago

@phil-davis, looks like the step is not used in any of the scenario. So, i am gonna delete it and make a PR.

prashant-gurung899 commented 2 days ago

@phil-davis, looks like the step is not used in any of the scenario. So, i am gonna delete it and make a PR.

And it looks like there are more stepDefinitions that are unused in any scenarios.