search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.26k stars 169 forks source link

[QA] cleanup test feature file for `@skiponRevaMaster` tag #9451

Closed S-Panta closed 6 days ago

S-Panta commented 1 week ago

Currently, we bump oCIS test only on Reva-edge. In the drone config, skiponReva is used to skip those tests on edge. Therefore using the @skiponrevamaster tag is redundant since the tag isn't used in the edge branch.

reva edge drone config file:

 "BEHAT_FILTER_TAGS": "~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@provisioning_api-app-required&&~@preview-extension-required&&~@local_storage&&~@skipOnOcis-OCIS-Storage&&~@skipOnGraph&&~@caldav&&~@carddav&&~@skipOnReva&&~@env-config",
S-Panta commented 1 week ago

@phil-davis Can we clean this tag?

phil-davis commented 1 week ago

@phil-davis Can we clean this tag?

Yes, it is old history. The current tests are aimed at the behavior of reva edge, and ocis. The behavior of reva master will be quite different. We have not been running on reva master for a long time, so we have no idea which scenarios would need this tag anyway.

Delete the tag.

amrita-shrestha commented 6 days ago

@S-Panta duplication of https://github.com/owncloud/ocis/issues/5337 so closing this issue