owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.36k stars 178 forks source link

[QA][API test] organize the test folders within the acceptance directory #9872

Closed saw-jan closed 2 weeks ago

saw-jan commented 3 weeks ago

In order to better scope and organize the files and folders related to API tests, here is a proposed acceptance directory structure.

Current:

📁tests
|--📁acceptance
|  |--📁features
|  |  |--📁apiSuiteX
|  |  |--📁bootstrap
|--📁TestHelpers

Proposed:

📁tests
|--📁acceptance
|  |--📁features
|  |  |--📁apiSuiteX
|  |--📁bootstrap
|  |--📁TestHelpers
saw-jan commented 3 weeks ago

CC @ScharfViktor @phil-davis

ScharfViktor commented 3 weeks ago

I agree 👍 One suggestion: maybe we can join make test-acceptance-from-core-api to make test-acceptance-api? but keep the old set naming (prefixes with core) to use only one command to run tests:

TEST_SERVER_URL="https://localhost:9200" \ BEHAT_FEATURE="tests/acceptance/features/coreApiWebdavOperations/downloadFile.feature:242" \ 
make test-acceptance-api
TEST_SERVER_URL="https://localhost:9200" \ 
BEHAT_FEATURE="tests/acceptance/features/apiGraph/activities.feature" \ 
make test-acceptance-api
phil-davis commented 3 weeks ago

I agree with the acceptance test folder restructuring.

I will let @saw-jan and @ScharfViktor decide what make command targets should do what things.

saw-jan commented 3 weeks ago

One suggestion: maybe we can join make test-acceptance-from-core-api to make test-acceptance-api? but keep the old set naming (prefixes with core) to use only one command to run tests:

currently, we have two different behat configs for them. But it looks doable. :+1: I will add to the list or create another ticket for this