search

owncloud / ocis

:atom_symbol: ownCloud Infinite Scale Stack
https://doc.owncloud.com/ocis/next/
Apache License 2.0
1.42k stars 183 forks source link

File picker for ONLYOFFICE #9951

Open ibnpetr opened 3 months ago

ibnpetr commented 3 months ago

The main idea:

Allow the user to:

  1. Open a new file without leaving the editor.

  2. Create a new file without leaving the editor.

Flow:

  1. Add “Open” and “Create” buttons to the File menu of OO to open the file selection dialog.

  2. The buttons will appear in the OO interface when the flags OpenDocumentPostMessage and CreateFilePostMessage are enabled, similar to other XXX-PostMessage flags.

  3. When the button is clicked, ONLYOFFICE will send a PostMessage: UI_OpenDocument and UI_CreateFile. (not based on the WOPI standard, but rather on an extension of Collabora's format.

  4. OC will handle these messages, display the file selection dialog, and open the file in a new tab.

micbar commented 2 months ago

@tbsbdr @AlexAndBear IMHO this is solved in a different way.

  1. In the ownCloud Web TopBar, click on the "Three Dots"
  2. Select "Open"
  3. Browse via the FilePicker
  4. Click on selected file to open it in a new tab

Screenshots

1725525072189

1725525101500

1725525127365

micbar commented 2 months ago

@dj4oC From our POV, this requirement is already fulfilled and needs no "custom" integration inside the OnlyOffice UI.

dj4oC commented 2 months ago

Was just working on the same and came to a similar clue. Can we add/enable a "new" button to the embedded web view? Then everything would be fine.

dj4oC commented 2 months ago

@micbar any progress on this item?

micbar commented 2 months ago

@tbsbdr @kulmann is that on your radar?

tbsbdr commented 2 months ago

Open a new file without leaving the editor.

✅ fulfilled via 3-dots menu -> open

Create a new file without leaving the editor.

@AlexAndBear can we add the New button in the filepicker? I think it makes sense to have it.

AlexAndBear commented 2 months ago

@tbsbdr Technically yes, but since this action is inside the iframe, we need to discuss what should happen when the file is created. We might also limit the file types that can be created, since you can't open odt files for example out of the text editor app

tbsbdr commented 2 months ago
  1. I'd say, when a file was created, it should just sit there (no auto-open) if feasible
  2. restricting to filetypes: i guess the user value is low, it could even be negative. I'd try to implement Nr 1 and see how it feels and if users complain about too many filetype options.
AlexAndBear commented 2 months ago

We need to check, but this can be an new ticket for the next sprint 👍

We can also think about having a new button in the top bar instead having it in the file picker