owncloud / openidconnect

OpenId Connect (OIDC) Integration for ownCloud
GNU General Public License v2.0
6 stars 2 forks source link

feat: JWT token will always be used for user info, expiry and verification #243

Closed DeepDiver1975 closed 2 years ago

DeepDiver1975 commented 2 years ago

Description

Whenever the given token is a JWT we try to use it for:

Motivation and Context

In some scenarios non JWT and JWT tokens can be used in parallel. We support this now.

Types of changes

Checklist:

Open tasks:

DeepDiver1975 commented 2 years ago

@mmattel once this is merged the config setting 'use-token-introspection-endpoint' is to be removed from the docs

mmattel commented 2 years ago

Will that PR finish "soon"? because we are doing QA on many new app releases including openidconect 😄

DeepDiver1975 commented 2 years ago

Will that PR finish "soon"? because we are doing QA on many new app releases including openidconect smile

This is not to be added to the next release.

DeepDiver1975 commented 2 years ago

refs https://github.com/owncloud/openidconnect/issues/241#issuecomment-1183139733

mmattel commented 2 years ago

Thanks for clarification 👍

DeepDiver1975 commented 2 years ago

@mmattel once this is merged the config setting 'use-token-introspection-endpoint' is to be removed from the docs

also use-access-token-payload-for-user-info will go @mmattel

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jnweiger commented 2 years ago

This is not to be added to the next release

Why not? openidconnect-2.2.0 is ready for QA. But you can still add this PR.

mmattel commented 2 years ago

Regarding the config.sample changes, these need to go into core and then transported to docs. I will file an issue in docs and a core pr.

DeepDiver1975 commented 2 years ago

Why not? openidconnect-2.2.0 is ready for QA. But you can still add this PR.

Well - 15 days ago the status of this all was different and I wanted to make sure that nothing breaks ....