search

owncloud / openidconnect

OpenId Connect (OIDC) Integration for ownCloud
GNU General Public License v2.0
5 stars 2 forks source link

feat: use OCP\Http\Client\IClientService #311

Open DeepDiver1975 opened 3 months ago

DeepDiver1975 commented 3 months ago

fixes https://github.com/owncloud/enterprise/issues/6606

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

IljaN commented 3 months ago

We should keep in mind that after this is merged we start to use core's cert-store while the previous implementation used the one from the OS. Could this break existing installations with self-signed certs are involved?

DeepDiver1975 commented 3 months ago

Could this break existing installations with self-signed certs are involved?

Possible - but that is the way it is ..... it was wrong from the first day to NOT use core's http client.

IljaN commented 3 months ago

Something for the release notes I guess. @jnweiger @pako81 https://github.com/owncloud/openidconnect/pull/311#issuecomment-2069157866