Closed lookacat closed 2 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
I am not quite sure if we should do this. It would be better to use a slot for the message and implement the contextualHelper there.
The slot method is not suitable because we create the modal via code, we have no option there to dynamically provide a template
As far as I know it will be rendered in the code via vue template anyways.So it should be quite possible to pass a new variable for the ct helper in web.
It's just not a good approach at the end to add a lot of components we have to the modal it self.
Rechecked, the slot won't be used in the app.vue, so I agree that's the easiest solution here.
Description
See https://github.com/owncloud/web/issues/6892#issuecomment-1245438400
Related Issue
https://github.com/owncloud/web/issues/6892
Motivation and Context
Why new props instead of using slot: So we can use it via code without markup
Screenshots (if appropriate):
Types of changes
Checklist: