owncloud / owncloud-sdk

:cloud: ownCloud client library for JavaScript
https://owncloud.dev/owncloud-sdk/
MIT License
75 stars 33 forks source link

sdk artifact broken when publishing to npmjs #1183

Closed kulmann closed 1 year ago

kulmann commented 1 year ago

The publish CI step publishes an artifact that only includes project meta files (license, readme, package.json), but not the sdk bundle (dist/owncloud.js). This became apparent when we tried to publish a final v3.0.0 yesterday (deleted the release on github, deprecated the release on npmjs).

See https://drone.owncloud.com/owncloud/owncloud-sdk/3965/11/5 for the CI run which published the broken artifact.

See https://unpkg.com/browse/owncloud-sdk@3.0.0/ for the contents of the broken artifact (note that there is no dist/owncloud.js present).

We already tried to debug this a little bit, but are not that deep into the caching logic that was set up in the sdk repo. Probably makes more sense if someone debugs this who has more clue. Debugging PR: https://github.com/owncloud/owncloud-sdk/pull/1182 -> revealed, that the dist folder which was supposedly restored from the cache is completely missing on disk when publishing the artifact. Feel free to further use this PR or close and debug in a different way.

cc @kiranparajuli589 @individual-it

kulmann commented 1 year ago

@individual-it the urgency on this issue changed. we'll soonish need to bring two enhancements in a new sdk release artifact to the web repo. Could you re-prioritize it please? 😇