owncloud / product

ownCloud Product Backlog
GNU Lesser General Public License v3.0
0 stars 1 forks source link

[ocis] oc:privatelink webdav property not returned #262

Closed dpakach closed 2 years ago

dpakach commented 4 years ago

On webdav responses oc:privatelink webdav properties are not returned

❯ curl -XPROPFIND https://localhost:9200/remote.php/webdav/Shares/hello.java --data-raw '<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns" ><d:prop><oc:privatelink/></d:prop></d:propfind>' -u marie:radioactivity -sk | xmllint  --format -
<?xml version="1.0" encoding="utf-8"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/webdav/Shares/hello.java</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink/>
      </d:prop>
      <d:status>HTTP/1.1 404 Not Found</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

in OC10

❯ curl -XPROPFIND http://localhost/fed/remote.php/webdav/block-aligned.txt -u admin:admin --data-raw '<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns" ><d:prop><oc:privatelink/></d:prop></d:propfind>' -sk | xmllint  --format -

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/fed/remote.php/webdav/block-aligned.txt</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink>http://localhost/fed/f/51</oc:privatelink>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>
butonic commented 3 years ago

rendering of the property implemented in https://github.com/cs3org/reva/pull/1604 ... but AFAICT oc10 renders different urls, depending on the ui that makes requests: old web ui or ocis web ...