owncloud / product

ownCloud Product Backlog
GNU Lesser General Public License v3.0
0 stars 1 forks source link

[OCIS] Sending a get request to groups endpoint is not case sensitive #283

Open dpakach opened 4 years ago

dpakach commented 4 years ago

steps

  1. create a group helloworld
  2. Try to get group HELLOWORLD

expected

group not found

actual

returns group helloworld

❯ curl -XGET https://localhost:9200/ocs/v2.php/cloud/groups -u admin:admin -ks | xmllint --format -
<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>200</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <groups>
      <element>philosophy-haters</element>
      <element>sysusers</element>
      <element>polonium-lovers</element>
      <element>radium-lovers</element>
      <element>violin-haters</element>
      <element>helloworld</element>
      <element>physics-lovers</element>
      <element>quantum-lovers</element>
      <element>sailing-lovers</element>
      <element>users</element>
    </groups>
  </data>
</ocs>

❯ curl -XGET https://localhost:9200/ocs/v2.php/cloud/groups/HELLOWORLD -u admin:admin -ks | xmllint --format -
<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>200</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <users/>
  </data>
</ocs>
kiranparajuli589 commented 3 years ago

tagged with toImplementOnOCIS on owncloud/core tests

https://github.com/owncloud/core/blob/6693b46de1a2abcf10d460caa5e5eaeaa2407679/tests/acceptance/features/apiProvisioningGroups-v1/addGroup.feature#L56-L69

phil-davis commented 3 years ago

Note: toImplementOnOCIS means that the test scenario does not run in regular CI of OCIS. In this case, the scenario has trouble cleanly deleting the different group(s) because of this issue. If we let the scenario run in CI, then it can leave behind groups that might effect later scenarios.

When a developer is fixing the "groups should be case-sensitive" issue, they should remove the toImplementOnOCIS from the test scenario in core and get it to pass.