Zotero integration + refactor and bug fixes of admin/personal panel

[mrow4a]

zotero required to add new personal panel to allow adding key. because of that I did not want to include more legacy logic, and I refactored the whole admin panel and fixed the bugs that were there.

in case not enabled

[mrow4a]

@jvillafanez most of this logic is just migrated , with few fixes for some obvious issues like button no longer displaying the section or inconsistent logic between settings or actually wrong logic for saving user settings.

[mrow4a]

@jnweiger would need translations in German (not sure how to organise this)

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
21 Code Smells

0.0% Coverage
0.0% Duplication

[jvillafanez]

I think we'll need some additional information about what is Zotero in the admin settings. Right now, as admin, I only see a checkbox to enable the feature, but I don't know if I need to do anything after clicking the checkbox. Is it an ownCloud feature? Is it a collabora feature? Do I need to setup a 3rd party service? Each user needs to provide an API key for zotero, but this isn't explained

I'd expect a quick explanation in the admin settings (more or less a "this is what you can expect by enabling this feature") with a couple of links to further official documentation, either in the ownCloud's documentation or collabora's

[mrow4a]

@jvillafanez I think some docs will come from Collabora or ownCloud after we release it. Then we could update it here.

but in general, admin allows users to provide keys and then Collabora would use them

[jnweiger]

I'd target this for a 4.1.0 release. 4.0.0 is in RC-Phase and P2. I don't want to delay that any further. I second the questions asked by @jvillafanez, In addition, I'd like to see instructions for a test setup. Server setup / keys ... demo data ...

Transifex requires that the code is in master. After that I can take care of translations, but that is not a priority currently.

[mrow4a]

@jnweiger this is fine. But then I nedd to submit seperate patch for secure view. One feature (from settings) broke when I did refactor for federation. We better include that one in 4.0.0.

[jnweiger]

@jnweiger this is fine. But then I nedd to submit seperate patch for secure view. One feature (from settings) broke when I did refactor for federation. We better include that one in 4.0.0.

Okay. Please target that refactor fix PR to the release-4.0.0 branch.

[mrow4a]

lets finish and merge after release-4.0.0 is done in https://github.com/owncloud/richdocuments/issues/501

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

0.0% Coverage
9.7% Duplication

[jnweiger]

German translations are at 100% currently, including zotero related strings. Praise to @EParzefall and Community translators.