search

owncloud / richdocuments

:notebook_with_decorative_cover: Collabora Online for ownCloud
116 stars 54 forks source link

'Office' view does not work any more with 4.0.0 #514

Closed timar closed 9 months ago

timar commented 9 months ago

I installed the pre-release 4.0.0 to two demo sites. The 'Office' view worked on neither of them. ownCloud version 10.12.2.1 and 10.13.1 (production)

Click on Office. image

Expected: something like this (screenshot from 3.0.0): image

Actual: ownCloud displayed 'Files' view.

jnweiger commented 9 months ago

Yes, same issue here. A blank page appears. And the Javascript console has an error:

grafik

jnweiger commented 9 months ago

https://github.com/owncloud/richdocuments/blob/master/js/documents.js#L732-L741

var path = $('li[data-fileid='+ id +']>a').attr('href');

I don't understand much of that javascript. I that some dom-tree expression syntax? It seems that id is empty. @mrow4a is that an issue?

mrow4a commented 9 months ago

I do not want to be too pesimistic but can be owncloud core broke this.

jnweiger commented 9 months ago

Not reproducable with richdocuments-3.0.0 on the latest greatest 10.13.1 Reproduced with richdocuments-4.0.0 on very old 10.11.0

mrow4a commented 9 months ago

hmm ok, I think I know what is the issue.. with federated shares probably did not notice it breaks other pannel.

mrow4a commented 9 months ago

fixed in https://github.com/owncloud/richdocuments/pull/517

jnweiger commented 9 months ago

Confirmed, #517 fixes the issue! Thanks Piotr!

jnweiger commented 9 months ago

Fixed in https://github.com/owncloud/richdocuments/releases/download/v4.0.0-rc.5/richdocuments-4.0.0-rc.5.tar.gz

@timar please re-review -- :eyeglasses: