Richdocuments complains about incorrect zotero api key

owncloud / richdocuments

:notebook_with_decorative_cover: Collabora Online for ownCloud

116 stars 54 forks source link

Richdocuments complains about incorrect zotero api key #527

Closed jnweiger closed 7 months ago

jnweiger commented 8 months ago

Seen with richdocuments-4.1.0-rc.1

do not configure anything about zotero in the settings.
just connect to a collabora server, as with 4.0.0 and before.
open any document in collabora, text, spreadsheet, presentation, drawing, or pdf: A message appears near the bottom. The zoero api key is incorrect. BAD

grafik

Expected behaviour:

this message should only appear, if zotero is enabled.

mrow4a commented 8 months ago

hmm weird, will check

jnweiger commented 7 months ago

Partially fixed in #529 -

there is no message, when a zotero key was never entered or deleted by saving empty. OK
The message still appears, when a random string was entered as zotero key. OK

But the message also appears, when the key was generated at https://www.zotero.org/settings/keys/new - BAD.

mrow4a commented 7 months ago

@jnweiger cannot reproduce. you need release of Collabora Online 22.05.10 at minimum. I also added now hint in the settings for this

jnweiger commented 7 months ago

Ok. So I cannot test this with the old unmaintained Collabora server that I have.

mrow4a commented 7 months ago

The good part is that if key is not specified it works as before. Rest, if this is a case, we need to entrust my local Zotero testing.

jnweiger commented 7 months ago

I've succeeded with the docker-compose setup from https://github.com/ValentinKruegl/owncloud_collabora and I've created a zotero api key for myself at https://www.zotero.org/juergen.weigert/library

I believe, the zotero plugin is enabled at the server. The /etc/coolwsd/coolwsd.xml file contains

   <zotero desc="Zotero plugin configuration. For more details about Zotero visit https://www.zotero.org/">
        <enable desc="Enable Zotero plugin." type="bool" default="true">true</enable>
    </zotero>

The collabora server has commit.history.core": "https://git.libreoffice.org/core/+log/cp-23.05.5-4",

But the same problem still exists: I always get

a) before I enter a key, b) after I enter the correct key c) when I enter a wrong key.

So I am afraid, if the key is not specified, then it does not work as before. All users will get this message, as soon as the admin enables zotero.

jnweiger commented 7 months ago

One issue is now identified, that fooled me probably most of the time: The Save button does not save what was pasted.

generate a zotero key. Or copy paste something else for demonstrtion purposes. I am using the text "Bibliography and Citation" from the settings page.
copy paste the key into Settings Personal Additional.

note, how the Save button has exactly the same gray, before and after pasting. BAD
Hitting Save does nothing. BAD. As a User, one might assume, there is by design no feedback after saving. We have it that way in other places.
Type 'X', see how the Save button changes to a darker text. OK

Now a click on the Save button is confirmed with a nice green 'Saved' message. OK.

For real world usage, the instruction to save needs to be:

Paste the zotero api key, then type something, then erase what you typed, then hit Save.

jnweiger commented 7 months ago

fixed in 4.1.0-rc.2