search

owncloud / richdocuments

:notebook_with_decorative_cover: Collabora Online for ownCloud
116 stars 54 forks source link

Zotero fixes for 4.1.0rc #529

Closed mrow4a closed 7 months ago

mrow4a commented 7 months ago

Fixes:

Screenshot for new input handling

Screenshot 2023-11-09 at 15 46 41 Screenshot 2023-11-10 at 08 18 12
mrow4a commented 7 months ago

@jnweiger added note that 22.05.10 is required in admin settings

jvillafanez commented 7 months ago

Update the existing key or save empty to delete

Just checking, is it true? Maybe I'm wrong, but if the value is empty, I think it will keep the current value or set an empty string (which I don't know how it will behave)

There is no message, when no key was entered, but there is a message when a correct key was entered.

I agree there should be some message. I think it's fixed, but I haven't tested it.

Code looks good to me.

mrow4a commented 7 months ago

@jnweiger could you rereview ? the adjustments are there.

mrow4a commented 7 months ago

@jnweiger @GeraldLeikam issue with the hiding button should be fixed now

mrow4a commented 7 months ago

@jnweiger fixed your very good catch with empty key

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication