search

owncloud / search_elastic

Elasticsearch based full text search
https://github.com/owncloud/search_elastic
GNU General Public License v2.0
8 stars 1 forks source link

Remove mismatch type return on Status/Entity #100

Closed skshetry closed 5 years ago

skshetry commented 5 years ago

Related to #99

In #98, I replaced the use of some function parameters to take Entity instead of the Status, to make it consistent, and to avoid creating intermediate child object from the parent. This creates Status object from existing Entity objects.

This is a parallel PR that solves the problem that #98 tries to as well, but I am not sure of returning Status from created Entity objects is correct, as during save on Entity, some changes might have been done.

codecov[bot] commented 5 years ago

Codecov Report

Merging #100 into master will decrease coverage by 0.05%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     15.27%   15.22%   -0.06%     
  Complexity      267      267              
============================================
  Files            24       24              
  Lines          1211     1215       +4     
============================================
  Hits            185      185              
- Misses         1026     1030       +4
Impacted Files Coverage Δ Complexity Δ
lib/Db/StatusMapper.php 0% <0%> (ø) 35 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 256fe23...f262eff. Read the comment docs.

skshetry commented 5 years ago

As #98 has been merged, this PR is not required, as it was alternative PR.