search

owncloud / search_elastic

Elasticsearch based full text search
https://github.com/owncloud/search_elastic
GNU General Public License v2.0
8 stars 1 forks source link

Fix wrong comparison in config service #102

Closed micbar closed 5 years ago

micbar commented 5 years ago

Part of https://github.com/owncloud/search_elastic/issues/99

codecov[bot] commented 5 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     15.25%   15.41%   +0.16%     
  Complexity      267      267              
============================================
  Files            24       24              
  Lines          1213     1213              
============================================
+ Hits            185      187       +2     
+ Misses         1028     1026       -2
Impacted Files Coverage Δ Complexity Δ
lib/SearchElasticConfigService.php 40.35% <100%> (+3.5%) 27 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b0e3e4...3d97319. Read the comment docs.

patrickjahns commented 5 years ago

Quick question - does resolving the value from the database convert it into a boolean? Otherwise we are having a issue with string and boolean strict comparison which will never result into true