Closed micbar closed 5 years ago
Merging #120 into master will increase coverage by
0.65%
. The diff coverage is33.33%
.
@@ Coverage Diff @@
## master #120 +/- ##
============================================
+ Coverage 18.93% 19.59% +0.65%
- Complexity 268 271 +3
============================================
Files 24 24
Lines 1183 1230 +47
============================================
+ Hits 224 241 +17
- Misses 959 989 +30
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
lib/SearchElasticService.php | 4.2% <ø> (ø) |
55 <0> (ø) |
:arrow_down: |
appinfo/Migrations/Version20170811211125.php | 0% <ø> (ø) |
2 <0> (ø) |
:arrow_down: |
lib/Jobs/DeleteJob.php | 27.77% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
lib/Search/ElasticSearchProvider.php | 0% <ø> (ø) |
16 <0> (ø) |
:arrow_down: |
lib/Jobs/UpdateContent.php | 0% <ø> (ø) |
12 <0> (ø) |
:arrow_down: |
appinfo/routes.php | 0% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
lib/AdminPanel.php | 0% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
lib/Jobs/UpdateMetadata.php | 0% <ø> (ø) |
9 <0> (ø) |
:arrow_down: |
appinfo/app.php | 0% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
lib/Db/StatusMapper.php | 2.94% <ø> (ø) |
35 <0> (ø) |
:arrow_down: |
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7cdceac...73e6619. Read the comment docs.
Changelog should be updated with latest 2 fixes:
@PVince81 CI issues are fixed. We could build the RC2 now, after all the other core release tasks.
@micbar sounds good. if you like we can do this together, unless you're already familiar with app building ?
Note: search_elastic CI is currently broken, see issue #152 ~Hopefully it will be great again soon.~ CI is great again.
CI is getting the problem we have been having today and yesterday with some docker images being slow to pull. I restarted drone.
@micbar release tag 1.0.0 has been made. Merge this? (it needs privs to merge because this repo is set to complain about "This branch is out-of-date with the base branch")
Description
Fixed
129
128
131