search

owncloud / search_elastic

Elasticsearch based full text search
https://github.com/owncloud/search_elastic
GNU General Public License v2.0
8 stars 1 forks source link

[Tests-Only] Fix unit tests related to core issue 37358 and core PR 37103 #173

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

Part of issue https://github.com/owncloud/core/issues/37358

The signature of core lib/private/User/Manager.php get() changed to have a new 2nd parameter. See core PR https://github.com/owncloud/core/pull/37103

Adjust unit tests so that the mocking of userManager matches the way that phpunit sees the calls. Even though the new parameter is optional (has a default value), phpunit sees the call happening with the parameter having been set to its default value false

codecov[bot] commented 4 years ago

Codecov Report

Merging #173 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #173   +/-   ##
=========================================
  Coverage     19.12%   19.12%           
  Complexity      278      278           
=========================================
  Files            24       24           
  Lines          1234     1234           
=========================================
  Hits            236      236           
  Misses          998      998

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5123cb0...21aa221. Read the comment docs.