search

owncloud / search_elastic

Elasticsearch based full text search
https://github.com/owncloud/search_elastic
GNU General Public License v2.0
8 stars 1 forks source link

No translations #306

Open phil-davis opened 1 year ago

phil-davis commented 1 year ago

Code in https://github.com/owncloud/search_elastic/blob/master/templates/settings/admin.php has translation calls like:

    <div class="field-margin-left-16">
        <button id="saveConfiguration"><?php p($l->t('Save Configuration'));?></button>
        <button id="rescan"><?php p($l->t('Rescan'));?></button>
        <label><input type="checkbox" /> <?php p($l->t('Scan external storages'));?></label>
        <br/><span class="message"></span>
    </div>

But no translation transfers from Transifex seem to be set up. The strings are always displayed in English, regardless of the language that the admin has selected.

Do we want the search-elastic admin UI to be translated?

If yes, then we need to setup the Transifex stuff.

If no, then we could remove the $l->t() translation calls. They are misleading if there are actually no translations in existence.