owncloud / search_elastic

Elasticsearch based full text search
https://github.com/owncloud/search_elastic
GNU General Public License v2.0
8 stars 1 forks source link

Consider Renaming files by the share receiver #62

Open micbar opened 5 years ago

micbar commented 5 years ago

Description

If a shared file is renamed by the sharee (share receiver) the sharee could not find the file searching for the new filename.

Steps to reproduce

1) Create "User01" and "User02" 2) Create file "good user experience.txt" with content "yes, for sure" as "User01" 3) run cron.php 4) Share file with "User02" 5) Log In as User02 6) Rename the file to "bad user experiance.txt" 7) Run cron.php 8) Search for "bad" -> no results

Cause of the problem

micbar commented 5 years ago

@butonic @patrickjahns found this already existing issue from last year.

davitol commented 5 years ago

@micbar Following the Steps to reproduce you posted in OP i was not able to reproduce the issue. Could you please retest if possible?

8\. Search for "bad" -> no results

The last step refers to user2 no?

micbar commented 5 years ago

@davitol Can you confirm, that your file was in a subfolder and not visible to the screen / view from where you searched?

davitol commented 5 years ago

@micbar No, it was in Home path, file visible to the view where I searched. I did not see if the issue was only related to files in subfolders...

davitol commented 5 years ago

file was in a subfolder and not visible to the screen / view from where you searched

With these conditions the issue is reproducible. Sorry for the noise

davitol commented 5 years ago

What it also happens is that file appears in the search looking for the old and the new name:

Screen Shot 2019-07-18 at 17 20 24 Screen Shot 2019-07-18 at 17 20 13

micbar commented 5 years ago

@davitol there is a difference in the search behavior between a filename on the current view and a filename in a folder.

1) The file on the same page is found by core js 2) The file somewhere else is found by elasticsearch, see "X search results in another folder"

This could lead to unexpected behavior.

micbar commented 3 months ago

unassigning.