micbar commented 5 years ago

Closes #88

VicDeo commented 5 years ago

@micbar this is what I mean. IMHO it would be better to put the warnings about destruction into command description.

> php occ help search:index:rebuild 
Usage:
  search:index:rebuild [options] [--] <user_id> (<user_id>)...

Arguments:
  user_id               Provide a userId. This argument is required.

Options:
  -q, --quiet           Do not output any message
  -f, --force           This command will delete all data in search index. Use this option to rebuild the search index without further questions.
  -h, --help            Display this help message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
      --no-warnings     Skip global warnings, show command output only
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Help:
  Rebuild the search index for a given User. If you want to rebuild the whole index, run "search:index:reset" and then "search:index:build --all

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will increase coverage by 0.29%. The diff coverage is 25%.

@@             Coverage Diff             @@
##             master     #89      +/-   ##
===========================================
+ Coverage        15%   15.3%   +0.29%     
- Complexity      264     268       +4     
===========================================
  Files            24      24              
  Lines          1173    1209      +36     
===========================================
+ Hits            176     185       +9     
- Misses          997    1024      +27

Impacted Files	Coverage Δ	Complexity Δ
lib/Command/Reset.php	`0% <0%> (ø)`	`4 <0> (+2)`	:arrow_up:
lib/Command/Rebuild.php	`84% <52.94%> (-16%)`	`9 <0> (+2)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffaa7d5...115fbf1. Read the comment docs.

owncloud / search_elastic

Ask security questions on destructive commands #89

Codecov Report