fix phan and phpstan reported errors

[individual-it]

phan and phstan were added to the test matrix, but a lot of errors were reported, so after ignoring them we need to fix them one by one see #72 and #90

[skshetry]

Only thing that needs to be done now, is, to change Entity to Status back. The PR #98 changed return type Status to Entity, but that was a mistake as it should really be Status.

This creates a lot of Call to Undefined function error. Other than this, other issues can be fixed as we find/stumble upon. This issue can be closed after the return type changes.

[micbar]

@sharidas Could you create more DEV Tasks for this and pair with @skshetry ?

Just look at the phan and stan configs and remove items from the ignore lists. Keep the tasks small :-)

[sharidas]

Dev tasks ( or subtasks ):

• https://github.com/owncloud/search_elastic/issues/107
• https://github.com/owncloud/search_elastic/issues/108
• https://github.com/owncloud/search_elastic/issues/109
• https://github.com/owncloud/search_elastic/issues/114

PS: Will continue adding, the more issues found.

[sharidas]

We ( me and @skshetry ) had discussed and created issues mentioned at https://github.com/owncloud/search_elastic/issues/99#issuecomment-502567539 and fixed them. As per our discussion, this is done.

[skshetry]

Close this? @individual-it

[phil-davis]

done as best as reasonable (i.e. stuff that has be be ignored is explicitly ignored, so if people write new code with dodgy stuff, it will fail the code standards checks)

[phil-davis]

PR #103 was just merged.