owncloud / smashbox

:collision: main test suite
GNU Affero General Public License v3.0
16 stars 6 forks source link

Add a test for public link download #129

Closed nickvergessen closed 9 years ago

nickvergessen commented 9 years ago

A simple test that covers https://github.com/owncloud/core/pull/19619

@PVince81 @DeepDiver1975

Before the fix (commit https://github.com/owncloud/core/commit/cd818e7419fb39d97683ecc5803534b0ed632596):

$ ./bin/smash lib/oc-tests/test_shareLink.py
[ ... cut ... ]
ERROR - publicDownloader - md5 of modified file /home/nickv/ownCloud/Smashbox/ramdir/test_shareLink-151007-154327/publicDownloader/TEST_FILE_LINK_SHARE.dat changed and should not have: expected 45b565af28a2998fa8d5dae7eb6e660e, got eb964678f7e0a61e833ae2e45e7d2119 "md5 of modified file %s changed and should not have: expected %s, got %s" % (fn, md5, actual_md5)) failed in expect_not_modified() ["/home/nickv/ownCloud/Smashbox/smashbox/python/smashbox/utilities/__init__.py" at line 692]
ERROR - publicDownloader - 1 error(s) reported

After the fix (commit https://github.com/owncloud/core/commit/f5c390fffd19971b97e54f0c32073523b38c6140):

Test passes :white_check_mark:

PVince81 commented 9 years ago

Nice :+1:

nickvergessen commented 9 years ago

Will try to cover full folder download and "some files" download as well

DeepDiver1975 commented 9 years ago

Will try to cover full folder download and "some files" download as well

NICE!

nickvergessen commented 9 years ago

Done

Covers:

PVince81 commented 9 years ago

:+1: