search

owncloud / smashbox

:collision: main test suite
GNU Affero General Public License v3.0
16 stars 6 forks source link

Fix the version comparison for alpha/beta/rc #144

Closed nickvergessen closed 8 years ago

nickvergessen commented 8 years ago

@ckamm should fix your version problems.

ckamm commented 8 years ago

@nickvergessen Should this PR target cernbox/smashbox?

nickvergessen commented 8 years ago

No, I will update the cernbox PR in a bit.

nickvergessen commented 8 years ago

@ckamm thanks for the hint with tuple comparison, I now made strings negative integers in the tuple, so tuple comparison passes correctly for those.

And since I didn't touch the test cases it behaves the same as before :)

nickvergessen commented 8 years ago

Also sent to cernbox in https://github.com/cernbox/smashbox/pull/60

nickvergessen commented 8 years ago

@PVince81 mind reviewing, so we can merge?

I ran our tests that use the method and they still pass.

ckamm commented 8 years ago

@nickvergessen :+1:

PVince81 commented 8 years ago

:+1: