search

owncloud / smashbox

:collision: main test suite
GNU Affero General Public License v3.0
16 stars 6 forks source link

Tests for aborted downloads #151

Closed PVince81 closed 7 years ago

PVince81 commented 7 years ago

This is a test to reproduce the issue https://github.com/owncloud/core/issues/22370 with PHP 7.

The only way to check if the issue occurs is by scraping the log file, so I improved that routine to download the file through the private API instead of copying. (copying failed on my envs due to different perms...)

Running this test is currently able to reproduce the issue after 10-15 iterations.

@DeepDiver1975 I think it would be fine to have a single executor for PHP 7 just for this one test, for now.

@jvillafanez @mrow4a please review

mention-bot commented 7 years ago

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @moscicki, @nickvergessen and @schnidrig to be potential reviewers.

PVince81 commented 7 years ago

Tested passed => this is wrong. Tests must fail on PHP 7

@DeepDiver1975 how are the PHP 7 smashbox tests going ?

PVince81 commented 7 years ago

Please review @jvillafanez @DeepDiver1975 @VicDeo @mrow4a, even if tests pass now I think it's fine to merge them. Once the PHP 7 env is there it will reveal the failure and then maybe people will be more interested in reviewing the matching fixes.

VicDeo commented 7 years ago

@PVince81 looks good except a typo :+1: