search

owncloud / testing

🔧 app for testing ownCloud
GNU Affero General Public License v3.0
3 stars 4 forks source link

Display banner on every page #13

Open PVince81 opened 6 years ago

PVince81 commented 6 years ago

In case someone somehow is running daily-qa-stable10 or some version of it containing the testing app, as this is insecure, show a banner on every page.

Could either be a yellow notification or inject some flashy DOM element in the header.

PVince81 commented 6 years ago

bonus point if it's animated

patrickjahns commented 6 years ago

@PVince81

Not sure if this is a good path to go - as it alters the DOM and might cause issue with UI testing. :/

VicDeo commented 6 years ago

what about CSS 'content' rule?

PVince81 commented 6 years ago

Not sure if this is a good path to go - as it alters the DOM and might cause issue with UI testing. :/

it might indeed. would need something unintrusive, hmmm...

phil-davis commented 6 years ago

As in the comments above, it changes what we are testing in UI tests. Specially it might interfere with tests that deal with notifications or error messages or even main menu button navigation.

PVince81 commented 6 years ago

you could also have a non-default setting that disables the banner

so if one would install the tarball, the banner is visible by default then test suites will set the config switch "disable annoying banner=true" so it stops loading the matching JS file.

but maybe that's already going too far for a rather unlikely case.

feel free to close