search

owncloud / testing

🔧 app for testing ownCloud
GNU Affero General Public License v3.0
3 stars 4 forks source link

Add tinySkeleton #171

Closed phil-davis closed 3 years ago

phil-davis commented 3 years ago

Description

See discussion in https://github.com/owncloud/core/issues/38607

oC10 does not really have "without skeleton files". If no skeleton directory is defined in config.php then the contents of core/skeleton are used as the skeleton for new users.

This PR adds tinySkeleton. There is just a placeholder .gitignore file in it. (Unfortunately, to commit a directory to git, the directory must contain at least 1 file). We can use this as the skeleton in acceptance tests whenever they specify "without skeleton files"

The objective is to be able to have a consistent file-system for "Alice", "Brian" etc when the acceptance test step specifies "without skeleton files". (Currently core git master and various release tarballs have different files in core/skeleton and that can cause inconsistencies in test results)

Checklist:

phil-davis commented 3 years ago

Comments/thoughts are welcome!

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dpakach commented 3 years ago

@phil-davis so even when we want to create a user without any skeleton files(or tiny skeleton), we will still have the .gitignore file there?

phil-davis commented 3 years ago

so do you want to use this tinySkeleton when the step says without skeleton or do you want to change all steps sating with tiny skeleton?

I am suggesting to use tinySkeleton when the step says without skeleton. (keeping the words in the feature files the same - the words are not strictly true, but they give the idea of what the user sees)

Actually in oC10 there is no such thing as "without skeleton". There can be an empty skeleton, but the backend code always finds some folder that is the "skeleton" and recursively copies whatever it finds there (which might be an "null" copy if the folder is empty).

I would like tinySkeleton to actually be emptySkeleton but I can't commit an empty folder to git. @dpakach Unfortunately the user ends up with .gitignore - maybe that is less harmful than welcome.txt ?