Expire a share - Githubissues

owncloud / testing

🔧 app for testing ownCloud

GNU Affero General Public License v3.0

3 stars 4 forks source link

Expire a share #173

Closed kiranparajuli589 closed 3 years ago

kiranparajuli589 commented 3 years ago

Description

expire an existing share

endpoint: /apps/testing/api/v1/expire-share/{share_id} method`: POST

sets share expiration date to yesterday
test added

Related Issue

https://github.com/owncloud/core/issues/36550

Motivation

works after core PR https://github.com/owncloud/core/pull/38793

phil-davis commented 3 years ago

I merged https://github.com/owncloud/core/pull/38793 this morning. So that will be part of daily-master-qa tonight. Tomorrow morning we should be able to run CI here and get a pass. Then we can merge this, and then try using it "for real" in test steps.

phil-davis commented 3 years ago

I fixed some code style, then squashed the commits.

kiranparajuli589 commented 3 years ago

i was trying to do the same 😄 btw, thank you PhilJI @phil-davis

phil-davis commented 3 years ago

And I had to skip the new expireShare tests on old oC10. The needed changes to core updateShare only exist in current core master, which will be the upcoming 10.8 release.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information