owncloud / testing

🔧 app for testing ownCloud
GNU Affero General Public License v3.0
3 stars 4 forks source link

Add api for checking if apache module is installed #97

Closed skshetry closed 5 years ago

skshetry commented 5 years ago

Description

This adds an API for checking if a given apache module is installed.

Currently, our testing setup requires mod_rewrite to be enabled for all tests to pass. Currently, we have no way to find that out. This is a generic solution that can check for any module that apache has enabled.

I plan to use this to check for mod_rewrite is whether enabled or not in the core, and provide helpful message on our test runner.

Checklist:

phil-davis commented 5 years ago

@skshetry please mention in the original post why this is a useful thing to have, and what core or app thing is planning to use it.

Also, I suspect that the acceptance tests will only pass on a system that is actually running Apache. e.g. when I run the tests on a local development machine that is just using the local PHP dev server, then the acceptance tests will not pass. I will try tomorrow, and we can think if there is a way to make the acceptance tests flexible.

skshetry commented 5 years ago

@phil-davis, yes, the acceptance test requires apache to pass atm. I have updated the description above.