Renamed test1 to user1 for notifications app acceptance tests

owncloud / testing

🔧 app for testing ownCloud

GNU Affero General Public License v3.0

3 stars 4 forks source link

Renamed test1 to user1 for notifications app acceptance tests #99

Closed Julian1998 closed 5 years ago

Julian1998 commented 5 years ago

Description

Renamed test1 to user1 for notifications app acceptance tests

Checklist:

[x] Latest changes are published according to instructions in README.md

individual-it commented 5 years ago

why is this needed?

Julian1998 commented 5 years ago

@individual-it Woups forgot about that part ;) https://github.com/owncloud/phoenix/pull/1205 The notifications acceptance test want the username to be test1... but in Phoenix we work with user1... are there any better solutions?

I could send the username as a parameter, but the default value test1 isn't needed anymore, am I right about that or do I miss sth?

individual-it commented 5 years ago

@Julian1998 here test1 is just the default for the case when no username is send. In you tests you should send the correct user in the user parameter

Julian1998 commented 5 years ago

@Julian1998 here test1 is just the default for the case when no username is send. In you tests you should send the correct user in the user parameter

Alright! Will do that! Thx :)