owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

webUI acceptance test failing intermittently #117

Closed phil-davis closed 5 years ago

phil-davis commented 5 years ago

webUI acceptance test scenario webUITwoFactorTOTP/keyVerification.feature:11 fails intermittently. https://drone.owncloud.com/owncloud/twofactor_totp/210/112

  Scenario: Verify using the key generated from the secret                                                           # /var/www/owncloud/apps/twofactor_totp/tests/acceptance/features/webUITwoFactorTOTP/keyVerification.feature:11
    Given user "newly-created-user" has logged in using the webUI                                                    # WebUILoginContext::theUserLogsInUsingTheWebUI()
    And the user has browsed to the personal security settings page                                                  # WebUIPersonalSecuritySettingsContext::theUserBrowsesToThePersonalSecuritySettingsPage()
    And the user has activated TOTP Second-factor auth but not verified                                              # TwoFactorTOTPContext::theUserHasActivatedTOTPSecondFactorAuthButNotVerified()
    When the user adds one-time key generated from the secret key using the webUI                                    # TwoFactorTOTPContext::theUserAddsVerficationKeyFromSecretKeyToVerifyUsingWebUI()
    Then the TOTP secret key should be verified on the webUI                                                         # TwoFactorTOTPContext::totpSecretKeyShouldBeVerifiecOnTheWebUI()
      The key could not be verified
      Failed asserting that false is true.
    And user "newly-created-user" using password "%regularuser%" should not be able to download file "textfile0.txt" # FeatureContext::userUsingPasswordShouldNotBeAbleToDownloadFile()
SCENARIO RESULT: (fail)

--- Failed scenarios:

/var/www/owncloud/apps/twofactor_totp/tests/acceptance/features/webUITwoFactorTOTP/keyVerification.feature:11

Make it reliable.

phil-davis commented 5 years ago

PR #116 should fix it.

phil-davis commented 5 years ago

PR #116 merged. Looks good. Please reopen this issue if a similar test fail happens.