search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Initial drone starlark #139

Closed phil-davis closed 5 years ago

phil-davis commented 5 years ago

Notes: 1) the previous drone.yml ran webUITwoFactorTOTP and cliTwoFactorTOTP acceptance test suites, but did not seem to run the apiTwoFactorTOTP acceptance test suite. That has been fixed here. 2) there were no tests with Oracle. When I tried to run PHP unit tests with Oracle, there were problems. See issue #140 3) The api and cli acceptance test suites actually need to do webUI actions in their scenario setup Given steps. They really need to run make test-acceptance-webui. So I have renamed the suites so that they start with webUI. That makes all the processing by starlark, Makefile and... work in the "standard" way. (Previously the suites looked like API and CLI suites but has @webUI tag in the feature files, which was tricky and did not work nicely with the starlark script)

codecov[bot] commented 5 years ago

Codecov Report

Merging #139 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     67.87%   67.87%           
  Complexity       67       67           
=========================================
  Files            14       14           
  Lines           277      277           
=========================================
  Hits            188      188           
  Misses           89       89

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b0ed09...31e42bd. Read the comment docs.