owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Error enabling twofactor_totp with Oracle #140

Closed phil-davis closed 4 years ago

phil-davis commented 5 years ago
php occ a:e twofactor_totp

In AbstractOracleDriver.php line 76:

  An exception occurred while executing 'CREATE TRIGGER "oc_twofactor_totp_se  
  crets_AI_PK"                                                                 
     BEFORE INSERT                                                             
     ON "oc_twofactor_totp_secrets"                                            
     FOR EACH ROW                                                              
  DECLARE                                                                      
     last_Sequence NUMBER;                                                     
     last_InsertID NUMBER;                                                     
  BEGIN                                                                        
     SELECT "oc_twofactor_totp_secrets_SEQ".NEXTVAL INTO :NEW."id" FROM DUAL;  
     IF (:NEW."id" IS NULL OR :NEW."id" = 0) THEN                              
        SELECT "oc_twofactor_totp_secrets_SEQ".NEXTVAL INTO :NEW."id" FROM DU  
  AL;                                                                          
     ELSE                                                                      
        SELECT NVL(Last_Number, 0) INTO last_Sequence                          
          FROM User_Sequences                                                  
         WHERE Sequence_Name = 'oc_twofactor_totp_secrets_SEQ';                
        SELECT :NEW."id" INTO last_InsertID FROM DUAL;                         
        WHILE (last_InsertID > last_Sequence) LOOP                             
           SELECT "oc_twofactor_totp_secrets_SEQ".NEXTVAL INTO last_Sequence   
  FROM DUAL;                                                                   
        END LOOP;                                                              
     END IF;                                                                   
  END;':                                                                       

  ORA-00972: identifier is too long                                            

In OCI8Exception.php line 33:

  ORA-00972: identifier is too long  

app:enable [-g|--groups GROUPS] [--] <app-id>

https://drone.owncloud.com/owncloud/twofactor_totp/444/10/4

Currently CI is not running any matrix entry with Oracle. I noticed this when I tried with Oracle.

Is Oracle supposed to be supported?

karakayasemi commented 4 years ago

The fix PR got merge in the upstream repo: doctrine/dbal#4106. It will be released next minor version of doctrine/dbal. When we update doctrine/dbal dependency in core, this issue will be resolved. Let's keep the issue open until oracle tests are reactivated in this repo.