search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Run TOTP acceptance tests on PHP 7.3 #145

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

phpunit tests are already running successfully with PHP 7.3

Add acceptance test runs with PHP 7.3 + core 10.3.0 to check that PHP 7.3 is fine.

codecov[bot] commented 4 years ago

Codecov Report

Merging #145 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #145   +/-   ##
=========================================
  Coverage     67.87%   67.87%           
  Complexity       67       67           
=========================================
  Files            14       14           
  Lines           277      277           
=========================================
  Hits            188      188           
  Misses           89       89

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f380ea...5cdcbf5. Read the comment docs.

phil-davis commented 4 years ago

@micbar the acceptance tests are running OK with PHP 7.3. IMO we might as well merge this, since it is useful to run with PHP 7.3 and it is not that big a test matrix.

If someone has a problem with this app and PHP 7.3, then please make an issue.

phil-davis commented 4 years ago

I restart drone CI - one of the jobs hung at install-testrunner and timed out.