search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

remove endroid/qrcode dependency to reduce package size #164

Closed karakayasemi closed 4 years ago

karakayasemi commented 4 years ago

The rebased version of https://github.com/owncloud/twofactor_totp/pull/113 closes #105

As discussed in #105, we wanted to migrate to a small QR code library to reduce tarball size. Therefore this PR changes endroid/qr-code with bacon/bacon-qr-code which is used by endroid for generating QR codes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #164 into master will increase coverage by 0.34%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
+ Coverage     67.75%   68.10%   +0.34%     
- Complexity       66       67       +1     
============================================
  Files            14       14              
  Lines           276      279       +3     
============================================
+ Hits            187      190       +3     
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
lib/Controller/SettingsController.php 91.66% <100.00%> (+0.75%) 9.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a205973...0de4518. Read the comment docs.

karakayasemi commented 4 years ago

@micbar this is an old sprint task issue, it waited long time for the ending support of php7.0. Now, it is ready to merge after your approval. Basically, it will reduce package size from 13 MB to less than 1 MB with a dependency package change.