search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

[Tests-Only] Run acceptance tests with php7.4 #169

Closed dpakach closed 4 years ago

dpakach commented 4 years ago

Related owncloud/QA#645

Run app acceptance tests with php7.4

phil-davis commented 4 years ago

Getting "random" fails like report in issue #170

codecov[bot] commented 4 years ago

Codecov Report

Merging #169 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     68.10%   68.10%           
  Complexity       67       67           
=========================================
  Files            14       14           
  Lines           279      279           
=========================================
  Hits            190      190           
  Misses           89       89

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26f3e39...1dd2dfb. Read the comment docs.

phil-davis commented 4 years ago

LGTM - passing with PHP 7.4. I will make a separate PR to increase <php min-version="7.1" max-version="7.3"/> to <php min-version="7.1" max-version="7.4"/>