search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Support PHP 7.4 #175

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

For some reason this app has a max PHP version specified. Increase it from 7.3 to 7.4.

An app release will be needed so people can use this with the upcoming core 10.5.0 on PHP 7.4

individual-it commented 4 years ago

looks like it needs some more tweaking image

phil-davis commented 4 years ago

Now I see - latest is of course some "old" version of core (e.g. 10.4.1). I can't test against that and run PHP 7.4. I added a commit to only test with core daily-master-qa on PHP 7.4.

codecov[bot] commented 4 years ago

Codecov Report

Merging #175 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     68.10%   68.10%           
  Complexity       67       67           
=========================================
  Files            14       14           
  Lines           279      279           
=========================================
  Hits            190      190           
  Misses           89       89

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ebc911...4159973. Read the comment docs.