owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Put back some error handling in acceptance tests #183

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

PR #172 added various error handling for when OTP generation failed, and also added a retry of the OTP generation.

The underlying cause was fixed in PR #182 (issue #170 ) and in that PR the code was PR #172 was reverted, which was generally good. We do not want to automatically retry OTP generation in the tests, we now want it to fail straight away if something goes wrong.

But it will be nice if it fails more nicely, and gives more clue about what went wrong.

Put back the error checking code from PR #172 that waits for the Verified text to come on the UI, and that checks isErrorMessagePresent. And if something goes wrong, then fail with a nice message.