search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

Update christian-riesen/otp to 2.6 #205

Closed phil-davis closed 3 years ago

phil-davis commented 3 years ago

christian-riesen/otp v2 has been out for a while. The major version release https://github.com/ChristianRiesen/otp/releases/tag/2.0.0 back in 2016 does not seem to have any real BC breaks, just a change to the supported PHP versions.

Fixes https://github.com/owncloud/twofactor_totp/issues/22

phil-davis commented 3 years ago

Unit tests fail, acceptance tests fail. So there are BC-breaks that need looking at!

phil-davis commented 3 years ago

@micbar I noticed this because there was a new patch release of 2.6

But the major version update requires some work. But probably not any urgent need for this.

micbar commented 3 years ago

@karakayasemi Can you take a look? It seems like we should upgrade to the 2.x version.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

karakayasemi commented 3 years ago

@phil-davis I have adjusted code and fixed the failing tests. The changes touches acceptance test context also. Please take a look at the changes and merge if it seems okay to you. I have approved the PR.