Closed hurradieweltgehtunter closed 2 years ago
I don't get it. Why is the drone build always killed?
@hurradieweltgehtunter This acceptance test fails: https://drone.owncloud.com/owncloud/twofactor_totp/1372/14/11
Fatal error: Call to a member function click() on null (Behat\Testwork\Call\Exception\FatalThrowableError)
The xpath for the submit action is wrong now: '//form/input[@type="submit"]'
(see https://github.com/owncloud/twofactor_totp/blob/master/tests/acceptance/features/lib/VerificationPage.php#L35).
The other tests were probably cancelled due to this.
Will take care about the tests soon
I put full-ci
in the PR title so that all test pipelines will run to completion. That will help to see all the tests that fail, in one pass.
@DeepDiver1975 @hurradieweltgehtunter CI should be green now, please review and merge, thx! We might need to create a release issue as well
What is the current status?
I rebased to get up-to-date CI. @hurradieweltgehtunter how do we move this forward?
Kudos, SonarCloud Quality Gate passed!
fixes: https://github.com/owncloud/twofactor_totp/issues/237 fixes: https://github.com/owncloud/twofactor_totp/issues/231