owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

[full-ci] Adapt to new login design #232

Closed hurradieweltgehtunter closed 2 years ago

hurradieweltgehtunter commented 2 years ago

fixes: https://github.com/owncloud/twofactor_totp/issues/237 fixes: https://github.com/owncloud/twofactor_totp/issues/231

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

hurradieweltgehtunter commented 2 years ago

I don't get it. Why is the drone build always killed?

JammingBen commented 2 years ago

@hurradieweltgehtunter This acceptance test fails: https://drone.owncloud.com/owncloud/twofactor_totp/1372/14/11

Fatal error: Call to a member function click() on null (Behat\Testwork\Call\Exception\FatalThrowableError)

The xpath for the submit action is wrong now: '//form/input[@type="submit"]' (see https://github.com/owncloud/twofactor_totp/blob/master/tests/acceptance/features/lib/VerificationPage.php#L35).

The other tests were probably cancelled due to this.

AlexAndBear commented 2 years ago

Will take care about the tests soon

phil-davis commented 2 years ago

I put full-ci in the PR title so that all test pipelines will run to completion. That will help to see all the tests that fail, in one pass.

AlexAndBear commented 2 years ago

@DeepDiver1975 @hurradieweltgehtunter CI should be green now, please review and merge, thx! We might need to create a release issue as well

prsnbrg commented 2 years ago

What is the current status?

phil-davis commented 2 years ago

I rebased to get up-to-date CI. @hurradieweltgehtunter how do we move this forward?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information