search

owncloud / twofactor_totp

🔑 Second factor TOTP (Google Authenticator) provider for ownCloud
GNU Affero General Public License v3.0
9 stars 9 forks source link

2FA login selection should be adapted to the new design #237

Open prsnbrg opened 2 years ago

prsnbrg commented 2 years ago

With oC 10.8 and latest twofactor_totp app the login selection for 2FA looks like this: image

I think the 2FA login selection should be adapted to the new design.

Also, it would help if the selections are displayed as buttons so each option can be easily identified as such. owncloud/core#38608

JammingBen commented 2 years ago

@hurradieweltgehtunter fyi

phil-davis commented 2 years ago

Also see issues: https://github.com/owncloud/twofactor_totp/issues/231 https://github.com/owncloud/twofactor_backup_codes/issues/30

xoxys commented 2 years ago

grafik

AlexAndBear commented 2 years ago

@hurradieweltgehtunter has those changes be merged, can we close the issue ?

hurradieweltgehtunter commented 2 years ago

AFAIK not, needs update in tests. Could you have a look? -> https://github.com/owncloud/twofactor_totp/pull/232

AlexAndBear commented 2 years ago

Sure 🙌

prsnbrg commented 2 years ago

The overview of 2fa options is implemented in core. Please reopen this issue.

There is the same graphical error as in this app. The line of the upper box is not continuous.

JammingBen commented 2 years ago

Reopening because we still have issues. It seems to be related to the selected language (=word length). When setting to German:

image