Unable to change Profile picture when LDAP directory has none

owncloud / user_ldap

📒

GNU Affero General Public License v3.0

17 stars 17 forks source link

Unable to change Profile picture when LDAP directory has none #231

Closed linkp closed 5 years ago

linkp commented 6 years ago

Steps to reproduce

Sign in with LDAP account on an LDAP directory that does not provide profile pictures
Navigate to Settings/General
Attempt to add profile picture

Expected behavior:

Click button
Upload image file
Crop
Save file
Enjoy fancy new profile picture

Actual behavior

There is no option to upload profile picture

Additional information

"Picture provided by original account" in displayed under generic letter avatar LDAP directory (JumpCloud in my instance) does not provide a means of including profile pictures

Versions

OS: Debian GNU/Linux 9.4 (stretch) Package: ownCloud Build Service stable (10.0.7-1.1)

patrickjahns commented 6 years ago

Can you please provide more information on your configuration? What version of the user_ldap app are you using?

linkp commented 6 years ago

I only show 1 version available in the marketplace, 0.10.0, which is what I have installed.

ronbailer commented 6 years ago

Same problem with OC 10.0.8 and LDAP 0.11.0.

Users who had avatar sets when we used local accounts (before LDAP migration) keep the images but cannot change them.

Looks like all that's left to do is add functionality to the interface.

jvillafanez commented 6 years ago

https://github.com/owncloud/user_ldap/pull/256 should fix the problem. The expected behaviour with the PR is described below:

A user without avatar in LDAP can add his own avatar.
A user with an avatar in LDAP cannot set his own avatar.
A user with or without avatar will be updated to the one from LDAP if it's added/changed.

This is expected to come with LDAP post-0.11.0 (0.12.0 maybe?)

linkp commented 5 years ago

The expected custom avatar functionality has been restored in v 0.12.0 published on 4 Nov 2018.

As noted in the the comments in #256, difficulty using it may occur due to a CSS overlap problem in OC Core covering the clickable are of the avatar buttons..