owncloud / user_ldap

📒
GNU Affero General Public License v3.0
17 stars 17 forks source link

Only trim on the string representation of an attribute #770

Closed IljaN closed 1 year ago

IljaN commented 1 year ago

Trimming on binary could potentially remove control-characters which are actually part of the binary attribute value.

jvillafanez commented 1 year ago

This should be good enough. I don't think that the string representation of the binary value will contain characters that could be trimmed. We might want to be more strict though.

IljaN commented 1 year ago
IljaN commented 1 year ago

I can't think up any scenario where a trim could "damage" the string representation.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication