owncloud / user_ldap

📒
GNU Affero General Public License v3.0
17 stars 17 forks source link

`phpstan` pipeline failing a nighty build #777

Closed SagarGi closed 1 year ago

SagarGi commented 1 year ago

Description

phpstan pipeline is failing on nightly build and seems to be a hard failure. Needs some investigation regarding it.

Line   lib/Access.php                                
 ------ ---------------------------------------------- 
  669    No error to ignore is reported on line 669.   
  2091   No error to ignore is reported on line 2091.  
 ------ ---------------------------------------------- 

 ------ --------------------------------------------- 
  Line   lib/User/Manager.php                         
 ------ --------------------------------------------- 
  163    No error to ignore is reported on line 163.  
 ------ --------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   lib/Wizard.php                                                         
 ------ ----------------------------------------------------------------------- 
         Ignored error pattern #Strict comparison using === between             
         non-falsy-string and '' will always evaluate to false.# in path        
         /var/www/owncloud/server/apps/user_ldap/lib/Wizard.php was not         
         matched in reported errors.                                            
  727    Method OCA\User_LDAP\Wizard::checkHost() is unused.                    
  873    Strict comparison using === between mixed and '' will always evaluate  
         to false.                                                              
 ------ ----------------------------------------------------------------------- 

Failed Build: https://drone.owncloud.com/owncloud/user_ldap/4363/2/4

phil-davis commented 1 year ago

Also see https://github.com/owncloud/encryption/issues/385

I will have a look at this also, and see if some of the reported problems are similar to the encryption false positive.