owncloud / user_ldap

📒
GNU Affero General Public License v3.0
17 stars 17 forks source link

Add condition in `doConnect` for checking network timeout is set #783

Closed pako81 closed 1 year ago

pako81 commented 1 year ago

Description

Add condition in doConnect for verifying network timeout is set.

Motivation and Context

Removing the Network Timeout value in the Advanced tab of the LDAP wizard is breaking the LDAP configuration with no hints whatsoever of what is wrong. There is no check in place in the WebUI to force the use of this option so we should add a condition to check if this is set when calling doConnect.

How Has This Been Tested?

Manually by removing the Network Timeout value in the Advanced tab of the LDAP wizard and checking the LDAP configuration is still healthy.

Types of changes

Checklist:

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication