owncloud / user_ldap

📒
GNU Affero General Public License v3.0
17 stars 17 forks source link

fix: search terms for binary fields will be converted if possible #815

Open jvillafanez opened 10 months ago

jvillafanez commented 10 months ago

Related to https://github.com/owncloud/enterprise/issues/6032

The app will take care of converting binary attributes when searching for them.

For example, if the user_ldap app has been configured the "user search attributes" with "objectguid" (among other attributes), searching by "36E271F3" might return results, assuming the converted value we have from binary contains those characters. Note that the converted value will also be stored as search term for the account in the "oc_account_terms" table.

jvillafanez commented 9 months ago

Failing tests are known: https://github.com/owncloud/user_ldap/issues/814

jvillafanez commented 9 months ago

I don't think I can add tests for the changes in the Access class easily. Need to change attributes in the connection class, which are accessed using magic methods. It doesn't seem possible to mock those.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
17.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pako81 commented 3 months ago

merge this?

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
17.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud