Open jvillafanez opened 10 months ago
Failing tests are known: https://github.com/owncloud/user_ldap/issues/814
I don't think I can add tests for the changes in the Access
class easily. Need to change attributes in the connection class, which are accessed using magic methods. It doesn't seem possible to mock those.
The SonarCloud Quality Gate passed, but some issues were introduced.
2 New issues
0 Security Hotspots
17.4% Coverage on New Code
0.0% Duplication on New Code
merge this?
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
17.4% Coverage on New Code
0.0% Duplication on New Code
Related to https://github.com/owncloud/enterprise/issues/6032
The app will take care of converting binary attributes when searching for them.
For example, if the user_ldap app has been configured the "user search attributes" with "objectguid" (among other attributes), searching by "36E271F3" might return results, assuming the converted value we have from binary contains those characters. Note that the converted value will also be stored as search term for the account in the "oc_account_terms" table.