owncloud / web-app-dicom-viewer

ownCloud Web DICOM Viewer is an extension of ownCloud Web to preview DICOM files (medical images and their corresponding metadata)
GNU Affero General Public License v3.0
3 stars 1 forks source link

Refactoring metadatahandling #16

Closed koebel closed 7 months ago

koebel commented 8 months ago

Description

Refactoring where Metadata is extracted and how it is handled in the app (data format/storage). Added extractMetadata helper class and tags look up table, adjusted test cases that included metadata props.

Related Issue

Fixes issues with extensive mocking and testability

Motivation and Context

previously the App.vue file had about 1000 lines of code and it was difficult to test. Separating the cornerstone core features from our own functionalities for extracting and handling metadata makes it easier to test (previously each test case required extensive mocking of cornerstone functions). The new solution is more modular and thus easier to scale/further extend and test.

Screenshots (if appropriate):

Types of changes

Checklist:

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud