owncloud / web-extensions

GNU Affero General Public License v3.0
1 stars 3 forks source link

feat: add unzip extension #39

Closed JammingBen closed 1 month ago

JammingBen commented 1 month ago

closes https://github.com/owncloud/web/issues/11264

AlexAndBear commented 1 month ago

Some nitpicks:

Other than that: 🚀

JammingBen commented 1 month ago
  • A sample file of 50mb takes super long, and gives the impression that the feature is broken (which isn't the case), we could think of decreasing the threshold drastically to 10MB or maybe show a message that it might take longer

@tbsbdr What do you think? I kinda like the idea of showing a message that it might take a while.

  • i18n is missing

Yep, we should definitely get this going for this repo: https://github.com/owncloud/web-extensions/issues/40

  • unit tests are missing

👍

  • doesn't work with the local docker setup

I just tried it, the app gets correctly shipped by oCIS for me. Extracting doesn't work though because the Web version bundled with oCIS is not up to date. Also, I get an error in the cast app: Cannot destructure property 'resources' of 'undefined' as it is undefined..

  • getting a csp error when running via Ocis 9200 instead of 9201 in web (docker)

True, that should be fixed.